search

doodlum / skyrim-community-shaders

Community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
187 stars 47 forks source link

fix: fix skylighting fade and darkness #517

Closed doodlum closed 2 months ago

doodlum commented 2 months ago

Also just some general cleanup and refactoring.

Some settings have been removed because either they are not relevant anymore, or were never used/confusing.

Fadeout code was separated to happen later on because otherwise it was not smooth (either on or off). Maybe this is fixable within the "sample" function I do not know.

Diffuse skylighting direction normals now never point downwards, to prevent issues with black surfaces whilst still maintaining a somewhat directional look.

alandtse commented 2 months ago

It's really hard for me to know what's going on because you're mixing a lot of different things. Were the settings removal responsible for the fix? At this point, I'll just approve since it's too hard for me to know what you are actually doing.