search

doodlum / skyrim-community-shaders

SKSE core plugin for community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
146 stars 43 forks source link

Particle shader breaks precipitation occlusion on recent test builds #558

Open XscapeTrekker opened 3 weeks ago

XscapeTrekker commented 3 weeks ago

On all test builds from at least as far back as early August, precipitation occlusion is broken whenever replacing the particle shader. Toggling on/off or otherwise changing any other settings don't affect the behavior. Tested on vanilla load order for 1.5.97 with only CS and Address Library active. When testing on the Nexus release with every Nexus feature active with same minimal load order, the particle shader is replaced by default and precipitation occlusion works perfectly fine. Using RTX 2080.

XscapeTrekker commented 1 day ago

I've done more testing on this to try and narrow the issue down to a specific feature. I removed the .ini for each feature one by one and regenerated a fresh shader cache attempting to isolate. In the end, the .ini for every feature was removed yet the issue persisted, so it seems core CS is breaking precipitation occlusion unless this testing method is flawed somehow. Hopefully this is helpful. Performed on Dev Test 2024-10-12

alandtse commented 20 hours ago

Did you try disabling individual shaders under Advanced -> Replace Original Shaders?

alandtse commented 18 hours ago

Also, explain what the issue is as I can't tell what "broken" means. Do you mean it rains under covered areas where vanilla doesn't? Provide a coc so we can find it and test it.

XscapeTrekker commented 17 hours ago

Yes, as explained in the initial post, the 'particle' shader is responsible for breaking precipitation occlusion. And by 'broken' I mean that precipitation is not occluded by roofs, walls, whatever objects the precipitation particles (snow, rain, ash) collide with. So yes, it rains and snows under or through covered/walled areas where vanilla doesn't. This can be seen just about anywhere with architecture during inclement weather.

To reproduce: coc whiterunexterior01 fw c8221 Go stand under the stables cover Toggle off 'Particle' under Advanced in CS menu to see precipitation occlusion working Toggle back on to see precipitation occlusion broken

To reiterate, toggling any other shaders or removing any/all features does not affect this. Also, with the current Nexus release, the 'Particle' shader does NOT exhibit this behavior. Happy to provide more info or test if you decide to look into this.

Also, for this feature to work in vanilla, this must be in SkyrimPrefs.ini [Display] section: bUsePrecipitationOcclusion=1

alandtse commented 16 hours ago

Ok thanks. Yes, the nexus release didn't have a customer particle shader if I remember correctly.

XscapeTrekker commented 16 hours ago

The particle shader is enabled by default on the Nexus release, but yeah, I wasn't sure whether or not it was actually doing anything.