search

doodlum / skyrim-community-shaders

Community-driven advanced graphics modifications for AE, SE and VR. Also fixes bugs and improves performance.
GNU General Public License v3.0
202 stars 49 forks source link

chore: improve settings, remove PBR settings #770

Closed doodlum closed 3 days ago

doodlum commented 4 days ago

If settings error they reset to default using a try catch loop. No more crashes. Settings are relocated under the CommunityShaders folder. They could be under their own Settings folder in that, but that might be annoying. I think it may be good though considering we will probably split things up more. Settings files are renamed to be clearer. PBR settings removed, they were pretty much testing code.

alandtse commented 4 days ago

These changes don't look like settings changes.

doodlum commented 4 days ago

These changes don't look like settings changes.

Removing the PBR settings was because I had to choose if I wanted to add the restore defaults and since we are probably removing anyway, made more sense.

alandtse commented 4 days ago

My point is your commit message is misleading.

doodlum commented 4 days ago

My point is your commit message is misleading.

Please suggest what changes should be made.

alandtse commented 4 days ago

The pr title should say remove PBR settings or whatever.