doofinder / doofinder-magento2

Open Software License 3.0
10 stars 9 forks source link

Problem with strings that can't be translated #272

Open santibm opened 1 year ago

santibm commented 1 year ago

On a customer feed we see the attribute availability with the label indexed in english:

{ "availability": "in stock", "best_price": 2.99, "categories": [ "Consumibles > Gas y CO2 > CO2", "Restock" ], "created_at": "2022-03-28 10:35:19",

When we search for the place where those labels are created we found these methods returning plain strings, they should probable be better returning the same strings with the translation function __('in stock')

https://github.com/doofinder/doofinder-magento2/blob/8d88624d1403be97676a6c2b8bbb1130b6fe23e4/Helper/Inventory.php#L247-L265