search

doom-neovim / doom-nvim

A Neovim configuration for the advanced martian hacker
GNU General Public License v2.0
1k stars 108 forks source link

[BUG] Lua lsp doesn't install #295

Closed Jakemate977 closed 2 years ago

Jakemate977 commented 2 years ago

Current Behavior:

The sumneko_lua lsp fails to install. Output of :LspInstallInfo: image

Expected Behavior:

sumneko_lua installs.

Steps To Reproduce:

  1. Enable the +lsp flag of lua.

Anything else:

The issue is already fixed in nvim-lsp-installer but since the packer dependency is pinned it is using a version that doesn't have the fix.

connorgmeehan commented 2 years ago

Pinning commits, damned if you do damned, if you dont :(. This is a tough one because nvim-lsp-installer has dropped 0.5 support entirely. I was hoping to do it when the module architecture released but should we just drop 0.5 support now @NTBBloodbath?

NTBBloodbath commented 2 years ago

Hey, I was thinking about dropping 0.5 after releasing the new incoming version but it seems that we will need to drop it asap. I'm totally fine with this decision, we could make a new release with the current development branch that has changes for 0.6 and 0.6.1 lsp changes and such stuff and update lsp-installer on it.

Jakemate977 commented 2 years ago

Totally unrelated question, but what is the difference between the develop and next branch?

connorgmeehan commented 2 years ago

Just to update you, we've fixed this on the develop branch and will be pushing a release to main soon (breaks 0.5 compatibility). Feel free to use develop if you'd like.

Regarding your question, we're currently re-writing a lot of the doom-nvim to make configuration more concise and make everything more modular and easier to maintain/contribute. There's a very large PR that we're still working on which is why there's not much of a difference between the two branches.

Jakemate977 commented 2 years ago

Ok, Thanks!

connorgmeehan commented 2 years ago

Hey just to let you know this has been resolved. There's a new release (v3.3.0) that you can pull that includes updated versions of everything. We've ended up just dropping 0.5 compatibility. Let me know if you have any issues!

Jakemate977 commented 2 years ago

Not sure if intentional, but you forgot to update the readme, anyways, thanks for your help