search

doom-neovim / doom-nvim

A Neovim configuration for the advanced martian hacker
GNU General Public License v2.0
1k stars 108 forks source link

[BUG][next] luacheck required? #363

Open baurmatt opened 2 years ago

baurmatt commented 2 years ago

Current Behavior:

[null-ls] [ERROR 16:17:39] ...t/null-ls.nvim/lua/null-ls/helpers/generator_factory.lua:180: command luacheck is not executable (make sure it's installed and on your $PATH)

Expected Behavior:

No error pops up :) The README doesn't mention luacheck as a dependency :)

Steps To Reproduce:

Logs

Check Health Output
Doom Report Output

Anything else:

connorgmeehan commented 2 years ago

Null-ls is a bit of a challenge because there's no auto-installer for it so it relies on system dependencies so if you want it to work you'll have to install it luarocks install luacheck. What's a good way to make it clearer to the user that it needs to be installed? I could at a note in the dependencies section of the readme.

Also thanks for these bugreports :) They don't seem to hard so I'll sort them out soon hopefully.

baurmatt commented 2 years ago

Ah, so this error popups up because lsp is now enabled by default for all languages unlike in the current stable where lsp is disable for lua by default? Does this affect other languages as well?

Can we disable it by default for lua? ;)

connorgmeehan commented 2 years ago

Ok now that https://github.com/williamboman/mason.nvim has been released this is something we'll implement for the next release.