search

doom-neovim / doom-nvim

A Neovim configuration for the advanced martian hacker
GNU General Public License v2.0
1.01k stars 107 forks source link

refact(core): Move doom settings to `doom.settings` field. #382

Closed molleweide closed 1 year ago

molleweide commented 2 years ago

moves settings table into root. doom.settings.<setting>

connorgmeehan commented 2 years ago

Thank you for these changes, I'll merge these changes with v4.1.x as I don't want to introduce breaking changes without including some new features / updates. (Mainly mason.nvim / auto installing LSP/DAP/linters etc and including DAP configs).

molleweide commented 2 years ago

The reason why some binds stopped working in the demo branch is because I forgot to replace the for loop in the whichkey module with tree. Now all binds came back to me. So now doom is fully compatible with any module structure and binds.

molleweide commented 2 years ago

I scrapped the dui module for now. I am going to finish some more of the functionality when I have time and add it again when some of the more fancy binds has been added so that I can show off a bit more :P

connorgmeehan commented 2 years ago

That's the only feedback I have, everything else looks good to me. If you address this issue I'll happily merge it in for v4.1 :) Also let me know if you need (also sorry about the merge conflicts, I had a look through them, apart from the changes to doom_global.lua, please take the latest upstream changes and add the doom.settings field where necessary. I can also do this if you like

molleweide commented 2 years ago

I cannot see where you put the feedback? Am I missing something or where do I see the feedback?