search

doomeer / factorio

Factorio Planner
MIT License
136 stars 39 forks source link

Many broken image links #25

Closed mmysinger closed 7 years ago

mmysinger commented 7 years ago

Many broken icon images links from the wiki started to appear recently. From a quick diagnosis, it looks like the majority can be fixed by switching the default space replacement character from dash ('-') to underscore ('_') for icons.

Grokzen commented 7 years ago

I noticed this also

pfrenssen commented 7 years ago

It would be better to host them locally instead of including the images directly from the Factorio wiki. Otherwise this will break again every time something changes upstream.

Bilka2 commented 7 years ago

I moved a lot of icons on the wiki around. You can find all things that I moved here. Left side are the new URL's, right side are the old ones. I don't think we will do such a mass move in the future, so you don't need to worry about this happening again. I'd not switch images hosts since you basically have automatically updating icons by using the wiki as a host.

Also as a heads up: Generally all pages on the wiki have titles as "Upper lower lower" case. While users do get redirected to the right page automatically, it might be easier if you'd directly link to the right page. We also try to use the in-game translations for pages names. You can find a mapping of page (and now also mostly icon) names to the factorio code names here.

Edit: I moved a few pages by hand instead of using the script which used the input that I linked. You can find all moves here. Moves performed by me (Bilka) and the last few moves by Gangsir might have been done manually.

NixonK commented 7 years ago

@Bilka2 Heya, I'm almost done with a pull request to fix this. Can you please also update the following image locations (they still have the old format and I assume they need to be changed to use underscores?): Shotgun Shell: Shotgun_shell.png Piercing Shotgun Shell: Piercing_shotgun_shell.png Active Provider Chest: Logistic_chest_active_provider.png Passive Provider Chest: Logistic_chest_passive_provider.png Storage Chest: Logistic_chest_storage.png Requester Chest: Logistic_chest_requester.png

Bilka2 commented 7 years ago

The 6 files you mentioned have been moved to their right locations according to the second link in my previous comment (in-game names).

doomeer commented 7 years ago

Thanks to all of you for this! I'm glad that the wiki images now have regular names.