search

doomeer / factorio

Factorio Planner
MIT License
137 stars 40 forks source link

Recipies for 0.17 #66

Closed SamuelWr closed 5 years ago

SamuelWr commented 5 years ago

Originally Lava84flow's PR, with minimal changes to make it compile

Lava84flow commented 5 years ago

Dur, didn't even see those other bits... I also don't really know OCaml, so..

keeshoekzema commented 5 years ago

You missed the Low Density Structure change in this PR, should be: [ 2., steel_plate; 20., copper_plate; 5., plastic_bar ] (https://wiki.factorio.com/index.php?title=Low_density_structure)

Also the name of the Stone Wall was changed to just Wall on the wiki

Lava84flow commented 5 years ago

dur... I didn't think that the low density stuff got changed

SamuelWr commented 5 years ago

@Lava84flow I wouldn't have seen it either without compiling it. As it was I spent 30 minutes getting the right compiler version and packages, and only about 10 fixing the compile errors

@keeshoekzema Thank you, I'll fix that

JensForstmann commented 5 years ago

Do you mind to commit the factorio.js as well. The readme states

factorio.js is the Javascript compiled from the OCaml code. It is included in the repository in case you don't want to compile it.

That would help me (and probably others) at lot.

doomeer commented 5 years ago

Hey, thanks a lot for your efforts! I see that I'll try to merge and publish this as soon as possible.

Don't worry about factorio.js, I always re-generate it anyway (otherwise one could commit a malicious one).