doomemacs / doomemacs

An Emacs framework for the stubborn martian hacker
MIT License
19.23k stars 3.04k forks source link

README.md -> Install should mention: "doom upgrade" needed to create and load default doom profile #8043

Closed johanwiden closed 1 week ago

johanwiden commented 1 week ago

I confirm that...

Expected behavior

This is just a lack of documentation. "doom install" does not create, and load, a default doom profile. Without such a profile, doom emacs will lack some fairly basic functionality. "doom upgrade" will create a default profile. This should be mentioned in README.md -> Install.

Current behavior

After "doom install", there is no doom profile. Some basic functionality is then missing in doom emacs: It is usable, but some common key bindings are missing, such as SPC-b-b, and SPC-f-s.

Steps to reproduce

  1. doom install
  2. start emacs
  3. SPC-b-b

System Information

https://pastebin.com/fETsp7N7

hlissner commented 1 week ago

I can't reproduce this. And I don't understand how you're using the term "profile" here, because the "default profile" is created no matter which of doom install, doom upgrade, or doom sync you use (they all call the equivalent of doom sync at the end).

Are you saying the profile init file in $EMACSDIR/.local/etc/@/init.*.el isn't getting created after running doom install? Or is the lack of keybinds the only behavior you've observed?

If it's the latter, than this has nothing to do with profiles, as Doom understands them, and instead indicates there was a runtime error at startup. Check the *Messages* buffer for warnings/errors. If you find one, produce a backtrace from it.

Otherwise, this may be a duplicate of https://github.com/doomemacs/doomemacs/issues/8026, which demonstrates a difference between doom install and doom sync which I haven't identified yet.

EDIT: Just realized that doom install isn't generating the profile bootloader, so you won't be able to launch other profiles after a doom install (which I'll fix shortly), but this should have no bearing on the default profile. I.e. This shouldn't be relevant to your issue unless your test case lives in a non-default profile.

johanwiden commented 1 week ago

A few days ago I did a reinstall of doom emacs, both under linux, and Android, due to git erroring out on with-editor during a doom upgrade.

At first I did not run "doom upgrade" after the install, and got the keybinding problem I described in the issue. When I then ran "doom upgrade", doom upgrade logged among other things “No profile loader found. Generating one…” I got this both in linux (emacs 29), and Android (emacs 30). After that I have the expected functionality.

Note that I was not making a completely fresh install, as I already have a ~/.config/doom directory. I just reinstalled ~/.config/emacs

If you still can not reproduce then I suggest you close the issue until I perhaps can provide more info. I do not think this is a serious problem, just a minor inconvenience.

Den ons 4 sep. 2024 kl 20:27 skrev Henrik Lissner @.***

:

I can't reproduce this. And I don't understand how you're using the term "profile" here, because the "default profile" is created no matter which of doom install, doom upgrade, or doom sync you use (they all call the equivalent of doom sync at the end).

Are you saying the profile init file in $EMACSDIR/.local/etc/@/init..el isn't getting created after running doom install? Or is the lack of keybinds the only* behavior you've observed?

If it's the latter, than that's indicative of a startup error. Check the Messages buffer https://discourse.doomemacs.org/t/how-to-debug-issues/55 for warnings/errors. If you find one, produce a backtrace https://discourse.doomemacs.org/t/what-is-a-backtrace-how-to-produce-them/85 from it.

Otherwise, this may be a duplicate of #8026 https://github.com/doomemacs/doomemacs/issues/8026, which demonstrates a difference between doom install and doom sync which I haven't identified yet.

— Reply to this email directly, view it on GitHub https://github.com/doomemacs/doomemacs/issues/8043#issuecomment-2329717575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOF7OL7PFBEOYDXNS4LGNDZU5GKHAVCNFSM6AAAAABNUMIEE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRZG4YTONJXGU . You are receiving this because you authored the thread.Message ID: @.***>

-- Johan Widén, tel: +46705367346 Risvägen 5 A, 192 73 Sollentuna, SWEDEN

johanwiden commented 1 week ago

Doom emacs now creates the profile loader during "doom install". Problem fixed.

hlissner commented 1 week ago

Thanks for letting me know! I'll mention this here for posterity: I believe this was fixed in https://github.com/doomemacs/doomemacs/commit/1a5ff08da4a1f011e6ec0697f672373517d224d6.