doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.15k stars 387 forks source link

Font size of line-number-current-line does not change with C-x C-+ #170

Closed ppwwyyxx closed 6 years ago

ppwwyyxx commented 6 years ago

Observed Behavior: Open emacs, use C-x C-+ or C-x C-- to change font size: 0426-15 48 25

It's probably caused by: https://github.com/hlissner/emacs-doom-themes/blob/ab2d572bbe70171c7396c795c1698888801b8b10/doom-themes-common.el#L67-L70

I found this can be fixed by:

(set-face-attribute 'line-number-current-line nil :inherit 'default)

Environtment:

Click to expand - OS: gnu/linux (x86_64-pc-linux-gnu) - Emacs: 27.0.50 (Apr 24, 2018) - Doom: 2.0.9 (develop https://github.com/hlissner/doom-emacs/commit/39b08b4d05fb754080f54011c8ee770a1d645a84) - Graphic display: t (daemon: nil) - System features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS NOTIFY ACL GNUTLS LIBXML2 FREETYPE LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS LIBSYSTEMD JSON LCMS2 - Details: ```elisp uname -a: Linux hawaii 4.15.15-1-ARCH #1 SMP PREEMPT Sat Mar 31 23:59:25 UTC 2018 x86_64 GNU/Linux modules: (:feature (debugger nil) (eval nil) (evil (+everywhere)) (file-templates nil) (lookup (+devdocs +docsets)) (services nil) (snippets nil) (spellcheck nil) (syntax-checker nil) (version-control nil) (workspaces nil) :completion (ivy nil) :ui (doom-dashboard nil) (doom-modeline nil) (doom-quit nil) (evil-goggles nil) (hl-todo nil) (nav-flash nil) (vi-tilde-fringe nil) (window-select nil) :tools (ein nil) (electric-indent nil) (eshell nil) (gist nil) (imenu nil) (impatient-mode nil) (make nil) (neotree nil) (password-store nil) (pdf nil) (rotate-text nil) (term nil) (tmux nil) (upload nil) :lang (cc nil) (data nil) (emacs-lisp nil) (ess nil) (go nil) (haskell (+intero)) (java (+meghanada)) (javascript nil) (latex nil) (lua nil) (markdown nil) (org (+attach +babel +capture +export +present +publish)) (python nil) (ruby nil) (sh nil) (web nil) :config) packages: (ace-link ace-window adaptive-wrap all-the-icons anaconda-mode android-mode async auctex auto-compile auto-yasnippet avy (centered-window :recipe (centered-window :fetcher github :repo anler/centered-window-mode)) cmake-mode coffee-mode command-log-mode company company-anaconda company-auctex company-dict (company-glsl :recipe (company-glsl :fetcher github :repo Kaali/company-glsl)) company-go company-inf-ruby company-irony company-irony-c-headers company-lua company-shell company-statistics company-web counsel counsel-css counsel-dash counsel-projectile cuda-mode demangle-mode devdocs dired-k disaster dockerfile-mode doom-themes dumb-jump editorconfig ein (emacs-snippets :recipe (emacs-snippets :fetcher github :repo hlissner/emacs-snippets :files (*))) emmet-mode eslintd-fix ess ess-R-data-view ess-smart-equals evil evil-anzu evil-args evil-collection evil-commentary evil-easymotion evil-embrace evil-escape evil-exchange evil-goggles evil-indent-plus evil-matchit evil-mc evil-multiedit evil-numbers evil-org evil-snipe evil-surround evil-textobj-anyblock evil-vimish-fold evil-visualstar (exec-path-from-shell :ignore t) expand-region flycheck flycheck-cask flycheck-irony flycheck-popup-tip flycheck-pos-tip flyspell flyspell-correct flyspell-correct-ivy fringe-helper gist git-gutter-fringe git-link git-timemachine gitconfig-mode gitignore-mode glsl-mode go-eldoc go-guru go-mode gorepl-mode graphql-mode groovy-mode haml-mode haskell-mode haxor-mode helpful hide-mode-line highlight-indentation highlight-numbers highlight-quoted hindent hl-todo htmlize hydra imenu-anywhere imenu-list impatient-mode inf-ruby intero irony irony-eldoc ivy ivy-bibtex ivy-hydra ivy-rich ivy-rtags ivy-xref js2-mode js2-refactor json-mode less-css-mode lua-mode macrostep makefile-executor markdown-mode markdown-toc meghanada mips-mode modern-cpp-font-lock moonscript multi-term nasm-mode nav-flash neotree nodejs-repl nose ob-go ob-mongo ob-sql-mode ob-translate opencl-mode (org-bullets :recipe (org-bullets :fetcher github :repo Kaligule/org-bullets)) org-download org-plus-contrib org-tree-slide (osx-clipboard :ignore t) overseer ox-pandoc ox-reveal pass password-store pcre2el pdf-tools persistent-soft persp-mode pip-requirements prodigy projectile pug-mode quelpa quickrun rainbow-delimiters rainbow-mode rake realgud rjsx-mode (rotate-text :recipe (rotate-text :fetcher github :repo debug-ito/rotate-text.el)) rspec-mode rtags ruby-refactor sass-mode shackle shrink-path skewer-mode slime smart-forward smartparens smex solaire-mode ssh-deploy stylus-mode swiper tide toc-org toml-mode typescript-mode undo-tree use-package vi-tilde-fringe vimrc-mode visual-fill-column web-beautify web-mode wgrep which-key xref-js2 yaml-mode yard-mode yasnippet) elc dirs: n/a exec-path: (/usr/local/bin /usr/local/sbin /usr/bin /opt/cuda/bin /usr/lib/jvm/default/bin /usr/bin/site_perl /usr/bin/vendor_perl /usr/bin/core_perl /bin /usr/sbin /sbin /usr/lib/emacs/27.0.50/x86_64-pc-linux-gnu) ```
hlissner commented 6 years ago

Hmm, but then you lose the matching background (with hl-line). Try this:

(set-face-attribute 'line-number-current-line nil :inherit '(hl-line default))
hlissner commented 6 years ago

My tests show that this fixes the issue. I've pushed the change in https://github.com/hlissner/emacs-doom-themes/commit/b3e3457e05cb8b067d94b323e625fb8317e80d42, which should resolve your issue. Feel free to reopen this if that isn't the case.

ppwwyyxx commented 6 years ago

Thanks!