doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.17k stars 395 forks source link

I have bug with doom-buffer-mode and icons neotree #39

Closed honnisha closed 7 years ago

honnisha commented 7 years ago

I have two bugs or I use something wrong.

First with this part: when I move between my frames, "doom-buffer-mode" is not change.

  ;; brighter source buffers
  (add-hook 'find-file-hook 'doom-buffer-mode)
  ;; brighter minibuffer when active
  (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
  ;; The temporary buffers ediff spins up aren't dimmed. You can fix this with:
  (add-hook 'ediff-prepare-buffer-hook 'doom-buffer-mode)

Second with neotree: something's wrong with the icons: 12

hlissner commented 7 years ago

About neotree:

Have you installed the fonts provided by all-the-icons? This is required to use their icons.

About doom-buffer-mode, that is strange. Could you provide a list of steps to reproduce that?

honnisha commented 7 years ago

Have you installed the fonts provided by all-the-icons? This is required to use their icons.

Yes, but I have symbols instead icons, its not important because its most likely all-the-icons issue.

screenshot_20170221_190501

About doom-buffer-mode, that is strange. Could you provide a list of steps to reproduce that?

doom-buffer-mode work well if I use it trough M-x. New created buffers created with doom-buffer-mode (not always), darker than others, but when i switch between buffers nothing changes.

This is my settings:

(use-package doom-themes
  :ensure t
  :config
  (setq doom-neotree-enable-file-icons t)
  (load-theme 'doom-one t) ;; or doom-dark, etc.
  (setq doom-enable-bold t    ; if nil, bolding are universally disabled
    doom-enable-italic t  ; if nil, italics are universally disabled

    doom-one-brighter-modeline nil
    doom-one-brighter-comments nil
    )
  ;; brighter source buffers
  (add-hook 'find-file-hook 'doom-buffer-mode)
  ;; brighter minibuffer when active
  (add-hook 'minibuffer-setup-hook 'doom-brighten-minibuffer)
  ;; The temporary buffers ediff spins up aren't dimmed. You can fix this with:
  (add-hook 'ediff-prepare-buffer-hook 'doom-buffer-mode)

  ;; Enable custom neotree theme
  (require 'doom-neotree)    ; all-the-icons fonts must be installed!
  ;; Enable nlinum line highlighting
  (require 'doom-nlinum)     ; requires nlinum and hl-line-mode
  )
hlissner commented 7 years ago

This is strange. It is possible that an error is occuring before doom-buffer-mode gets run. You may want to check view-echo-area-messages to see if there are any error messages (coming from another part of your emacs config).

If there aren't any, here is an alternative solution that works for me:

  (defun doom*brighter-buffer-maybe (buffer &rest _)
    (when (and (not doom-buffer-mode)
               buffer-file-name)
      (doom-buffer-mode +1)))
  (advice-add 'switch-to-buffer :after 'doom*brighter-buffer-maybe)
  (advice-add 'display-buffer   :after 'doom*brighter-buffer-maybe)

You do not need (add-hook 'find-file-hook 'doom-buffer-mode) with this.

Let me know if that solves your problem.


As for neotree, I don't think it's a neotree issue. I am using doom-themes neotree mod (on Arch Linux) and it works fine. From the screenshot, it looks like it's not recognizing the fonts.

hlissner commented 7 years ago

Whoops, ignore that doom-popup-p call in the above code. That's only for my emacs.d. I've corrected it now.

honnisha commented 7 years ago

Nothing changes with doom*brighter-buffer-maybe. Nothing in Messages buffer.

Its strange, because doom-buffer-mode work as well trough M-x, but (add-hook 'find-file-hook 'doom-buffer-mode) doesn't work at all. How can I test add-hook 'find-file-hook? I don't know how to use elisp.

honnisha commented 7 years ago

I tried on computer and on my laptop. Both are use Kubuntu, the result is the same.I tried to leave only the doom-themes settings in .emacs, it still doesn't work. Any clues?

p.s. I start use https://github.com/mina86/auto-dim-other-buffers.el instead doom-buffer-mode, works for me.