[Colour accuracy issue] doom-dark+ (vscode) theme too vibrant?

[ianyepan]

In the screenshot below (Visual Studio Code left, Emacs right), we can see that the colours in Emacs are more vibrant than those in Visual Studio Code (use a colour-hex-detector if you find the differences too small), despite supposedly using the same theme. The vibrancy includes the green comments, the blue keywords and yellow functions etc. As if there has been a vibrancy filter that was masked over my Emacs interface and the contrast was tuned higher. @ema2159 Hi Emmanuel! I believe you were the original author of this port -- how did you fetch the official colours from VSCode? On second thought, it could potentially be the problem in how an 'electron' app renders the same colours though -- in which case it's not an issue of doom-themes at all.

[ema2159]

That's a pretty good question. I would need to look further into it. As I remember, I got the colors from here: https://github.com/microsoft/vscode/blob/master/extensions/theme-defaults/themes/dark_plus.json Not only that file but some others inside that repo. All the colors seem right, except for the comments that seem a little bit off. I'll try to check what's going on

[ianyepan]

Thanks! For your reference, I'm on macOS Catalina using the default Colour LCD display profile.

[ianyepan]

@ema2159 I came across the thread, might be of help for those interested: https://github.com/microsoft/vscode/issues/65816

[ema2159]

@ianpan870102 interesting, so it was Windows's VS Code fault all along?

[ianyepan]

The colour rendering issue has been found on macOS, Windows, and Linux platforms -- I think you meant "Microsoft's" VSCode fault right? That'd be my best guess too, since I double checked the colours defined in VSCode's theme and they are indeed not the right colours if I detect it system-wide. This doom-theme port has chosen the official colours of VSCode. My port of vscode-emacs theme (https://github.com/ianpan870102/vscode-dark-plus-emacs-theme) took the approach of hand-picking every colour using a colour picker directly from the UI, so you could say that it "looks" the most like VSCode, but it won't be the official colours -- since VSCode can't display their official colours either. Hope this makes sense.

[ianyepan]

To conclude, the doom-theme "too vibrant" issue is actually how VSCode should look like.

[ema2159]

@ianpan870102 that's cool. So it seems VS Code has problems rendering colors properly who would've thought. Should we close the issue then?

[ianyepan]

Sure, I'll close this one.

[ianyepan]

@ema2159 Hi there! So the other day I was having a look in Microsoft's vscode github repo and extracted these colours:

Official colors from Microsoft's Visual Studio Code:
"#DCDCAA"
"#4EC9B0"
"#C586C0"
"#9CDCFE"
"#51B6C4"
"#CE9178"
"#d16969"
"#d7ba7d"
"#569cd6"
"#C8C8C8"
"#d4d4d4"
"#b5cea8"
"#f44747"
"#6A9955"

It seems that they have "updated" their color scheme, because the red and magenta are consistent with the ones in doom-dark+, but the others (blue, teal, yellow, etc.) are not.