The doom-gruvbox theme applies strikethrough to replacement text

[ghost]

EDIT: Sorry, this is for doom-emacs-themes During an ex replacement, the doom-gruvbox theme uses the evil-ex-substitute-matches face to visualise the old text and inherits it to the evil-ex-substitute-replacement face to visualise the new text. However, it forgets to turn off the strikethrough.

--- a/themes/doom-gruvbox-theme.el  2020-09-25 12:03:05.710502521 +1200
+++ b/themes/doom-gruvbox-theme.el  2020-09-25 12:04:53.875671363 +1200
@@ -141,7 +141,7 @@
    (isearch :foreground base0 :background orange)
    (evil-search-highlight-persist-highlight-face :background yellow)
    (lazy-highlight :background yellow :foreground base0 :distant-foreground base0 :bold bold)
-   (evil-ex-substitute-replacement :foreground cyan :inherit 'evil-ex-substitute-matches)
+   (evil-ex-substitute-replacement :foreground cyan :strike-through nil :inherit 'evil-ex-substitute-matches)

    ;; evil-snipe
    (evil-snipe-first-match-face :foreground "white" :background yellow)

Steps to reproduce:

1. SPC-h-t doom-gruvbox
2. SPC-. \<any-old-file-with-text>
3. :%s/\<old>/\<new>/g
4. note strikethough on \<new> text

System information:

SYSTEM  type       gnu/linux
        config     x86_64-redhat-linux-gnu
        shell      /bin/bash
        uname      Linux 5.8.10-200.fc32.x86_64 hlissner/doom-emacs#1 SMP Thu Sep 17 16:48:25 UTC 2020 x86_64
        path       (~/.local/bin /usr/local/bin /usr/local/sbin /usr/bin /usr/sbin /usr/libexec/emacs/27.1/x86_64-redhat-linux-gnu/)
EMACS   dir        ~/.config/emacs/
        version    27.1
        build      Aug 21, 2020
        buildopts  --build=x86_64-redhat-linux-gnu --host=x86_64-redhat-linux-gnu --program-prefix= --disable-dependency-tracking --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib64 --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info --with-dbus --with-gif --with-jpeg --with-png --with-rsvg --with-tiff --with-xft --with-xpm --with-x-toolkit=gtk3 --with-gpm=no --with-xwidgets --with-modules --with-harfbuzz --with-cairo --with-json build_alias=x86_64-redhat-linux-gnu host_alias=x86_64-redhat-linux-gnu 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection' LDFLAGS=-Wl,-z,relro PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig
        features   XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD JSON PDUMPER GMP
        traits     (server-running envvar-file)
DOOM    dir        ~/.config/doom/
        version    2.0.9
        build      grafted, HEAD -> develop, origin/develop, origin/HEAD 1456108 2020-09-10 18:03:32 -0400
        elc-files  0
        modules    (:completion company ivy :ui doom doom-dashboard doom-quit hl-todo modeline ophints (popup +defaults) vc-gutter vi-tilde-fringe workspaces zen :editor (evil +everywhere) file-templates fold multiple-cursors snippets :emacs dired electric ibuffer undo vc :term eshell :checkers syntax (spell +flyspell) :tools (eval +overlay) (lookup +dictionary) magit pass :lang emacs-lisp markdown org sh :email mu4e :app calendar (rss +org) :config (default +bindings +smartparens))
        packages   ((evil-tutor))
        unpin      (n/a)
        elpa       (n/a)

[ronisbr]

I am also having this problem. It seems to be happening only in doom-gruvbox theme.

[ronisbr]

@kbmad btw, do you plan to make a PR to fix this? I can do if you don't mind.

[ghost]

@kbmad btw, do you plan to make a PR to fix this? I can do if you don't mind.

Please go ahead, thanks.