Too hard to see what's being selected when using ivy

[nobellium1997]

This was the issue I was having on discord in the help-nondoom channel

@gagbo

What happened?

When using ivy, the current selection is too hard to see. The background blends in with the minibuffer so it's impossible to tell what you are currently selecting.

What did you expect to happen?

Either some underline/different background color to indicate what your current selection is.

Steps to reproduce

1. Install the ivy package.
2. Run something like counsel-M-x or any function that uses ivy completion.
3. Try navigating up and down the list of selections.

System Information

• Emacs version: 28.0.50
• Emacs distro: Doom Emacs
• Operating system: Ubuntu 20.04
• Installed commit of doom-themes: 9e2680b
• Which theme are you using: doom-acario-light

The purple "company-mode" option is not the current selection. On my monitor, that screenshot doesn't appear to be selecting anything but that's not to say that others won't be able to see the selection. This might just be a me issue.

My work around was to just add an underline to the ivy-current-match face which works fine.

(after! ivy
  (set-face-attribute 'ivy-current-match nil :underline t))

[myme]

Similar issue with doom-dracula in terminal using vertico. When switching to e.g. doom-one and back again the current selection face suddenly has a darker background and so becomes distinguishable. However, that seems more like a bug of not resetting faces properly.

[gagbo]

I'm not sure it's the same as doom-dracula and doom-one as you suggest. The contrast between the light blue background of the selected candidate and the yellow-ish default background is just terrible. I should look into fixing that

[DPDmancul]

In vertico with opera-light there is the opposite problem: the description has a similar color of the highlighted background, and so it's not readable:

[gagbo]

Hello,

You should make a separate issue for this. When I (or someone else) comes around and fixes acario-themes, It's going to close this issue automatically