search

doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.15k stars 390 forks source link

doom-themes-enable-bold appears to have opposite behavior of what is documented #666

Open jeep opened 2 years ago

jeep commented 2 years ago

What did you expect to happen?

When doom-themes-enable-bold is t, bold should be enabled. When it is nil, bold should be disabled.

What actually happened?

When doom-themes-enable-bold is t, bold is disabled. When it is nil, it is enabled. bold-true bold-nil

Describe your attempts to resolve the issue

I tried switching to other themes and the same behavior occurs in doom-vibrant, doom-spacemacs

Steps to reproduce

  1. Read the documentation on doom-theme-enable-bold and notice is says: If nil, bold will be disabled across all faces.
  2. Open a .org file (I didn't check other modes)
  3. Make a bold word using asterisks. bold
  4. Open variable definition for doom-theme-enable-bold to see the value
  5. Invert and see if it still occurs

Package commit

e716ddbb882a3a06744faa74decb2fea1569c921

System Information

Windows 10 with WSL in an Ubuntu 20.04 terminal.

hlissner commented 2 years ago

doom-themes-enable-bold only prevents :bold and :weight attributes on faces Doom sets. It has no control over faces that it doesn't set, or face attributes set inline. There is no way around this because Emacs doesn't provide us a way to "disable/ignore all bolding" across all faces.

Once v3.0 of this package is done, I'll remove this variable since it's misleading (and the package will offer other ways to "iterate" over faces).

jeep commented 2 years ago

I'm trying to understand this response, will you please confirm my understanding?

'doom-themes-enable-bold' will, when nil, set bold to base8 so it can be distinguished (from your comment in #667). When t, however, it doesn't affect org-mode. So my issue is not related to this package, but for some reason org mode isn't rendering bold text.

Is that correct?