search

doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.14k stars 383 forks source link

solarized-light: excessively low contrast in gnus and erc #668

Open memeplex opened 2 years ago

memeplex commented 2 years ago

What did you expect to happen?

When I open a news group with gnus I expect to get a visual cue that a post is marked as read, but not to the point that makes the message unreadable.

What actually happened?

image

Describe your attempts to resolve the issue

No response

Steps to reproduce

  1. Configure gnus to open gmane (setq gnus-select-method '(nntp "news.gmane.io")).
  2. Run gnus with M-x gnus.
  3. List all groups with AA.
  4. Subscribe to some group with u.
  5. Read some message in the group.

Package commit

e716ddbb882a3a06744faa74decb2fea1569c921

System Information

macOS Big Sur, emacs-28 branch built from sources with defaults + svg support.

memeplex commented 2 years ago

erc has also too low contrast cases, although not as much as gnus:

image

memeplex commented 2 years ago

Also: image

memeplex commented 2 years ago 
     `(gnus-group-mail-1-empty ((t (:foreground ,(doom-color 'base6)))))
     `(gnus-summary-normal-ancient ((t (:foreground ,(doom-color 'base6)))))

Moving these two faces fg from base5 to base6 produces a more legible output. gnus-group-mail-1-empty is inherited by many xxx-empty faces, in fact the face for the above screenshot is gnus-group-mail-3-empty, which inherits from gnus-group-mail-1-empty.