search

doomemacs / themes

A megapack of themes for GNU Emacs.
MIT License
2.16k stars 390 forks source link

Slant inconsistent in solarized-light vs solarized-dark #814

Open real-or-random opened 9 months ago

real-or-random commented 9 months ago

Theme(s)

doom-solarized-dark, doom-solarized-light

What were you expecting?

Comment slant should be the same in solarized-light vs solarized-dark.

What actually happened?

Slant is italics in the light variant since https://github.com/doomemacs/themes/commit/3abb53e1ab22aab3454d9a2ef983277a4c19e66b, but it's upright in the dark variant.

Steps to reproduce

  1. Open a source file with comments
  2. Toggle between solarized-light and solarized-dark.

Operating system

Arch Linux

Emacs version

29.1

Installed commit of doom-themes

abd29569a6b78515599c2133fcb06da3e06bee14

real-or-random commented 9 months ago

It depends a bit if you consider this a bug. But it's rather annoying when you switch between the dark and the light variant often, e.g., with auto-dark-mode.

I'm happy to submit a PR, but then I need to know whether we want italics or not. I don't really have a preference. I thought @hlissner may have an opinion because he worked on https://github.com/doomemacs/themes/commit/3abb53e1ab22aab3454d9a2ef983277a4c19e66b