search

doomhack / GBADoom

A port of prBoom to the Nintendo GBA.
214 stars 27 forks source link

Remove GodMode in Floor type-11 and automate building process. #29

Closed ez-me closed 2 years ago

ez-me commented 2 years ago

Vanilla removes IDDQD cheat when finishing E1M8 for example, but this source port doesn't have that.

Also made it so that you can more easily build the rom by just opening msys2.bat, instead of also having to type "make"

doomhack commented 2 years ago

Looks good to me. Thank you.

Kippykip commented 1 year ago

Huh yeah I guess the original has player->cheats &= ~CF_GODMODE; instead Not sure if it matters though

FrenkelS commented 1 year ago

I mean in the original code cheats &= ~CF_GODMODE; isn't behind an if-statement, while P_DamageMobj (player->mo, NULL, NULL, 20); is. But here it's the other way around.

FrenkelS commented 1 year ago

Come to think of it, there's a difference between cheats &= ~CF_GODMODE and cheats -= CF_GODMODE. The first one turns of the GodMode cheat flag, If you don't have any cheats activated, cheats is 0, then cheats -= CF_GODMODE will make cheats == -2 which is equal to 11111110b with a lot more leading 1s, which turns on the GodMode cheat flag, and NoMomentum and EnemyRockets.