search

doomsider / DTSD

StarMade Daemon
GNU General Public License v2.0
1 stars 2 forks source link

No auto termination of the screensession for sm_log #2

Closed tschaerni closed 10 years ago

tschaerni commented 10 years ago

As the Title says, there is not auto termination for the session when the Script (and server) stops with sm_ebrake or sm_stop. The way with kill $PID is good but i think screen -S $SCREENLOG -X quit would be a better way.

Cheers

doomsider commented 10 years ago

The primary logging script in the logging screen only runs while the server is active. Once the server shuts down this other screen will self terminate just as the starmade server screen does. If for some reason the screen is left open the script will first wipe inactive screens and then close any existing screens.

This system works fine, but if you feel another level of redundancy is in order feel free to add it. Also I will accept anything you would like to add to Github. The script is meant for everyone to work on and improve. Thanks for taking a look at the Script, it has taken a lot of work to get this far and I have a lot of plans for the future.

On Wed, Aug 6, 2014 at 7:23 AM, Robin Cerny notifications@github.com wrote:

As the Title says, there is not auto termination for the session when the Script (and server) stops with sm_ebrake or sm_stop. The way with kill $PID is good but i think screen -S $SCREENLOG -X quit would be a better way.

Cheers

  • tschaerni

— Reply to this email directly or view it on GitHub https://github.com/doomsider/DTSD/issues/2.

tschaerni commented 10 years ago

I have also wrote a Banksystem, and months ago, i have also wrote a Warp System, based on the V13 of your Script ;)

Your system is okay for a Server that runs 24/7 and have multiple restarts a day etc. But when i use it for testing purposes (mostly tweaking your script) it doesn't kill/terminate the session when the server is shutting down. It will bi killed and restarted if the server is back online. It is mostly a cosmetic Problem, but it is nice if the script make a clean exit. I will improve this idea and make a commit when it is stable.

Cheers

doomsider commented 10 years ago

Ohh cool! Well if you want to work together on the daemon a little I would welcome it. I can add you as a contributor on Github if you like.

Yeah I test a lot myself as well but have not had this issue with screens not terminating lately. In the past I did so I added that screen wipe and the check to make sure nothing else is running.

On Thu, Aug 7, 2014 at 9:01 AM, Robin Cerny notifications@github.com wrote:

I have also wrote a Banksystem, and months ago, i have also wrote a Warp System, based on the V13 of your Script ;)

Your system is okay for a Server that runs 24/7 and have multiple restarts a day etc. But when i use it for testing purposes (mostly tweaking your script) it doesn't kill/terminate the session when the server is shutting down. It will bi killed and restarted if the server is back online. It is mostly a cosmetic Problem, but it is nice if the script make a clean exit. I will improve this idea and make a commit when it is stable.

Cheers

  • tschaerni

— Reply to this email directly or view it on GitHub https://github.com/doomsider/DTSD/issues/2#issuecomment-51483822.

tschaerni commented 10 years ago

Nice :D

I will push my improvements if i have more of them :3

Is it possible to have a better way to discuss? (I think this issue thread isn't the best place) You can contact me under robin@cerny.li

PS: You can close this Issue, it isn't any more an issue (:

doomsider commented 10 years ago

Well I hang out with a lot of developers in Skype: rhard4u12

On Fri, Aug 8, 2014 at 2:56 AM, Robin Cerny notifications@github.com wrote:

Nice :D

I will push my improvements if i have more of them :3

Is it possible to have a better way to discuss? (I think this issue thread isn't the best place) You can contact me under robin@cerny.li

— Reply to this email directly or view it on GitHub https://github.com/doomsider/DTSD/issues/2#issuecomment-51578134.

tschaerni commented 10 years ago

This isn't an option for me, i don't like Microsoft, and I don't use Skype :/ As an idea, you know IRC? We can use the official IRC Channel from Starmade, or we can make a new one (:

Cheers

doomsider commented 10 years ago

Yeah I have no love for MS or Skype myself, but it is what a lot of people use so I go along with it. I am going to setup a XMMP server with a java chat client in the next few days.

On Sun, Aug 10, 2014 at 8:24 AM, Robin Cerny notifications@github.com wrote:

This isn't an option for me, i don't like Microsoft, and I don't use Skype :/ As an idea, you know IRC? We can use the official IRC Channel from Starmade, or we can make a new one (:

Cheers

  • tschaerni

— Reply to this email directly or view it on GitHub https://github.com/doomsider/DTSD/issues/2#issuecomment-51716208.