search

doomspork / artifact

File upload and on-the-fly processing for Elixir
Apache License 2.0
44 stars 2 forks source link

Fix some issues I had with the docs! #6

Closed aphillipo closed 8 years ago

aphillipo commented 8 years ago

Hi Doomspork, Thanks for artifact it looks fantastic; I had some issues and have updated the docs accordingly!

doomspork commented 8 years ago

Thanks @aphillipo, I left some feedback. Could you squash when we're done?

aphillipo commented 8 years ago

Yep, I'll be able to look at this in an hour or so - not sure when the UI for squishing commits is coming but it really isn't soon enough :-)

Maybe you need to turn it on explicitly?

doomspork commented 8 years ago

I forgot about that new feature. I haven't used it yet but I'll take a look.

aphillipo commented 8 years ago

Okay this is done! Thanks for your comments, I agree with them all and they are implemented.

Only one extra line about installing imagemagick - everyone has this installed so might be unimportant :-)

doomspork commented 8 years ago

This is great, thank you @aphillipo :+1: