search

doonfrs / pluto_grid_plus

PlutoGrid is a dataGrid for flutter that can be controlled by the keyboard on desktop and web. Of course, it works well on Android and IOS.
https://pluto.weblaze.dev
MIT License
18 stars 20 forks source link

[Other] Pull requests from old repo? #7

Closed bastaware closed 6 months ago

bastaware commented 7 months ago

Will the pull requests from the old repo be merged in? Or do they have to be created again?

I have this pretty simple PR laying dormant: https://github.com/bosskmk/pluto_grid/pull/852/commits/a0c0601375d9880d4b2dd08e84e167c14e758b1d

doonfrs commented 6 months ago

Hi @bastaware could you please explain why did you use utc? I am afraid this solution may not work for all timezones.

bastaware commented 6 months ago

The problem appears in the months of change summer/wintertime. The days count will be wrong because of the missing/extra hour.

utc works because there is no summer/winter time. I'm sure there are other solutions to this, it just seemed as an easy fix.

It can easily be testet:

https://github.com/bosskmk/pluto_grid/issues/826

doonfrs commented 6 months ago

Thank you, could you please create the PR on the current package, I will review & merge it.

Macacoazul01 commented 6 months ago

@doonfrs im gonna send a message in each pr from the 20 in the original package.

which you already merged?