Update issuer configuration to allow dynamic values

doorkeeper-gem / doorkeeper-openid_connect

OpenID Connect extension for Doorkeeper

MIT License

175 stars 117 forks source link

Update issuer configuration to allow dynamic values #144

Closed ship-happens closed 3 years ago

ship-happens commented 3 years ago

Proposing a small change here so that issuer accepts a string or a block. This is useful in cases where Doorkeeper API mode is enabled and requests are proxied from multiple hosts, so that the value may be set dynamically from the resource owner and/or application. Please let me know if you have any concerns. Thanks!

toupeira commented 3 years ago

@maxxsnake thanks, this LGTM and makes sense! :+1:

I'll go ahead and merge this, and will also update the README to mention the block syntax.