doorkeeper-gem / doorkeeper-openid_connect

OpenID Connect extension for Doorkeeper
MIT License
173 stars 115 forks source link

allow to use custom doorkeeper access grant model #168

Closed nov closed 2 years ago

nov commented 2 years ago

Since this gem is hard-coding Doorkeeper::AccessGrant in some places, it prevents using custom doorkeeper model. So this pull request replaces it with Doorkeeper.config.access_grant_model with doorkeeper gem version check.

nov commented 2 years ago

Hi @nbulaj,

Could you please review this pull request? I believe you're the best person since you are the maintainer of both doorkeeper & doorkeeper-openid_connect gem.

thanks!

nov commented 2 years ago

Thank you for your merge. Do you have any plan to release new version with these changes?

nbulaj commented 2 years ago

Released as 1.8.2 @nov https://github.com/doorkeeper-gem/doorkeeper-openid_connect/releases/tag/v1.8.2

nov commented 2 years ago

thanks!