NameError: uninitialized constant Doorkeeper::JWT::JWK

doorkeeper-gem / doorkeeper-openid_connect

OpenID Connect extension for Doorkeeper

MIT License

173 stars 114 forks source link

NameError: uninitialized constant Doorkeeper::JWT::JWK #197

Closed michael-cybrid closed 1 year ago

michael-cybrid commented 1 year ago

Issue

Getting NameError: uninitialized constant Doorkeeper::JWT::JWK when calling as_jws_token on Doorkeeper::OpenidConnect::IdToken
This was introduced in https://github.com/doorkeeper-gem/doorkeeper-openid_connect/pull/194 by @stanhu with the line ::JWT::JWK.new(key, { kid_generator: JWT::JWK::Thumbprint })

Possible Fix

That line should instead be ::JWT::JWK.new(key, { kid_generator: ::JWT::JWK::Thumbprint })

stanhu commented 1 year ago

Submitted #198.

What Ruby version are you using by chance? I wasn't able to reproduce this on Ruby 3.0 or 3.1, and we've had this code running in production for over a month.

michael-cybrid commented 1 year ago

Sorry, didn't see this response; I am using ruby 3.2.2 (2023-03-30 revision e51014f9c0) [arm64-darwin21].

stanhu commented 1 year ago

🤷 Ruby 3.2.2 passes for me locally as well.

@nbulaj Could you look at #198?

nbulaj commented 1 year ago

Sorry, github closes automatically.

@michael-cybrid could you please install the master branch of the gem and check if everything is OK? I will release then in case of success

michael-cybrid commented 1 year ago

Verified; the fix works. Thanks!

nbulaj commented 1 year ago

Released with 1.8.7, thanks