search

doorkeeper-gem / doorkeeper-openid_connect

OpenID Connect extension for Doorkeeper
MIT License
175 stars 117 forks source link

ci: make all tests pass again #214

Closed stanhu closed 1 day ago

stanhu commented 2 weeks ago

The tests were failing because the current gemspec allows sqlite3 >= 1.3.6, but the external Gemfiles used older versions.

To avoid this, BUNDLE_GEMFILE needs to be set as documented in https://github.com/ruby/setup-ruby:

To use a Gemfile which is not at the root or has a different name, set BUNDLE_GEMFILE in the env at the job level as shown in the example.

stanhu commented 1 week ago

@toupeira Ok, this should looks like it's all green now. 😄

stanhu commented 1 week ago

Spoke too soon. Looks like mutex_m is being moved to a bundled gem in Ruby head: https://bugs.ruby-lang.org/issues/19885

grzesiek commented 1 week ago

+1

stanhu commented 1 week ago

@toupeira Could you take a look at this? We haven't heard from @nbulaj for a while. I'm also happy to take on maintainership duties if you want to add me to this project and Rubygems.

nbulaj commented 1 week ago

Hey @stanhu . I see all your hard-work for this project, but unfortunately I’m in a hospital with pneumonia so I’ll be able to check all these later

stanhu commented 1 week ago

@nbulaj Oh, no, I'm sorry to hear that! I hope you get better soon.

stanhu commented 1 day ago

@nbulaj Hope you are feeling better. Thanks for the merge!

When you get a chance, could you tag a new release? Thank you!