search

doorkeeper-gem / doorkeeper-openid_connect

OpenID Connect extension for Doorkeeper
MIT License
173 stars 114 forks source link

[meta] Looking for maintainers! #89

Open toupeira opened 4 years ago

toupeira commented 4 years ago

I'm increasingly neglecting this gem because I'm not really using it in any of my current projects, and working with OAuth / OIDC is just generally causing me a lot of headaches :stuck_out_tongue:

If anybody wants to become a maintainer, please let me know!

/cc @nashby @nbulaj

giubueno commented 4 years ago

Ping me.

nbulaj commented 4 years ago

@toupeira I will provide a support for this gem (as doorkeeper maintainer), like some bugfixes and improvements, but not new features. Could you please check if I have permissions to push to rubygems? I have something more to merge soon, and we need to release a new version with a fixes to support latest Doorkeeper (5.4).

toupeira commented 4 years ago

@nbulaj thanks! :+1:

And yes you should have permission:

$ gem owner doorkeeper-openid_connect
Owners for gem: doorkeeper-openid_connect
- nikita_bulai
- ops@playonsports.com
- markus-koller@gmx.ch
mecampbellsoup commented 3 years ago

and working with OAuth / OIDC is just generally causing me a lot of headaches 😛

Out of curiosity (as we embark on a buy-vs-build decision at our company) could you elaborate on these headaches?!

toupeira commented 3 years ago

@mecampbellsoup well, just take a look at the length and complexity of these specs :grin:

But joking aside, I originally started extending this gem so we could support OIDC in GitLab, so it's used quite widely (especially at Siemens, who originally sponsored that contribution), and @nbulaj and me are still around now and then to look after bugfixes and other small improvements.

And really most of the heavy lifting is done in the main Doorkeeper gem, so if you're tied to Rails I don't think there's a good reason to start from scratch :slightly_smiling_face: You might be interested in https://github.com/nov/openid_connect though, if you're looking for more of a library rather than a Railsy framework solution.

mecampbellsoup commented 3 years ago

@mecampbellsoup well, just take a look at the length and complexity of these specs 😁

But joking aside, I originally started extending this gem so we could support OIDC in GitLab, so it's used quite widely (especially at Siemens, who originally sponsored that contribution), and @nbulaj and me are still around now and then to look after bugfixes and other small improvements.

And really most of the heavy lifting is done in the main Doorkeeper gem, so if you're tied to Rails I don't think there's a good reason to start from scratch 🙂 You might be interested in nov/openid_connect though, if you're looking for more of a library rather than a Railsy framework solution.

To be sure, we would use this library if we went with Ruby. However we are more likely to use Python due to ... well, other concerns not related to this conversation.

I was more curious whether you were suggesting that:

toupeira commented 3 years ago

@mecampbellsoup I'm not opposed to OIDC at all, it seems perfectly fine if you want to build your own SSO, and OAuth2 will probably crop up anyway if you want to integrate with other services.

Regarding hosted SSOs, I don't have much experience with them and zero knowledge about your business so I can't really give you any advice :wink: But I do know that Auth0 and Okta also offer OIDC and are certified providers: https://openid.net/certification/

stanhu commented 1 year ago

@toupeira Do you think you could add me here?

toupeira commented 1 year ago

@stanhu oh hey, sorry for the delay! Turns out the notifications for this repository were still getting sent to my old gitlab.com address :sweat_smile:

I haven't been active here in a while, so I'll leave this decision to @nbulaj who's taken over the helm. For context, Stan works at GitLab and I trust him fully, and I myself have left GitLab earlier this year :slightly_smiling_face:

nbulaj commented 1 year ago

Oh, @stanhu do you still interested in helping maintaining the gem? Just let me know please :pray: Sorry didn't have enough time to read all the discussions.

pboling commented 1 week ago

It's interesting that the readme points to the official list of certified client/server libraries for OpenID Connect, which only has one Ruby library listed, (https://gitlab.com/os85/rodauth-oauth). Was this library previously certified? Or is the link there to subtly hint that people ought to look into using a different library?

toupeira commented 1 week ago

@pboling oh, that link points to http://openid.net/developers/libraries/ which now redirects to https://openid.net/developers/certified-openid-connect-implementations/. At the time I added it it was just a collection of libraries and clients, and IIRC this gem was on there too :wink:

The gem was never certified though, back then it was only possible to certify specific deployments but I see they now also list "Certified OpenID Provider Libraries". We tried to get the gitlab.com deployment certified, but that didn't go anywhere due to lack of interest: https://gitlab.com/gitlab-org/gitlab/-/issues/414305

I did use https://gitlab.com/openid/conformance-suite to check conformity and iron out bugs, so if anybody wants to take this topic up again it should be mostly there on the technical side. :crossed_fingers: