search

doorkeeper-gem / doorkeeper

Doorkeeper is an OAuth 2 provider for Ruby on Rails / Grape.
https://doorkeeper.gitbook.io/guides/
MIT License
5.34k stars 1.07k forks source link

Improve developer experience #1736

Closed ThisIsMissEm closed 1 month ago

ThisIsMissEm commented 1 month ago

Summary

Whilst working on #1735, I noticed it was hard to debug the code, this change adds a fairly opinionated way to debug the code when developing the doorkeeper gem. Additionally I've fixed the warning in the tests that I mentioned in #1732.

Now when developing in either the code or the specs, you can use the debugger keyword to jump into an interactive debugging session.

Other Information

Why include irb in the Gemfile? That's been recommended by the irb authors, due to irb bundled with ruby frequently being out of date with the state of irb development.

nbulaj commented 1 month ago

Hm interesting that 1 test started to fail :thinking:

ThisIsMissEm commented 1 month ago

Hm interesting that 1 test started to fail 🤔

I think that test case may be flakey, have seen failures for it in other branches too

stanhu commented 3 weeks ago

This change broke tests for Rails < 7.1: https://github.com/doorkeeper-gem/doorkeeper/pull/1742. I don't think this was flaky.