search

doorstop-dev / doorstop

Requirements management using version control.
https://doorstop.readthedocs.io
Other
474 stars 132 forks source link

Updating openpyxl to >=3.0.7 #583

Closed myrontuttle closed 2 years ago

myrontuttle commented 2 years ago

Updating so that doorstop can be used in the same project as openai python package which has a dependency on openpyxl>=3.0.7. Testing passed on my Windows machine using poetry run pytest doorstop (Makefile had issues which seemed to be about Windows). This is my first pull request on GitHub and I'm still pretty new with python, so if there's anything else needed to contribute please let me know.

codecov-commenter commented 2 years ago

Codecov Report

Merging #583 (127ab9d) into develop (dcc67c0) will decrease coverage by 0.11%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #583      +/-   ##
===========================================
- Coverage    95.07%   94.95%   -0.12%     
===========================================
  Files           36       35       -1     
  Lines         4852     4840      -12     
  Branches       961      929      -32     
===========================================
- Hits          4613     4596      -17     
- Misses         142      147       +5     
  Partials        97       97
Impacted Files Coverage Δ
doorstop/server/utilities.py 80.00% <0.00%> (-8.00%) :arrow_down:
doorstop/server/main.py 91.24% <0.00%> (-2.19%) :arrow_down:
doorstop/__init__.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

jacebrowning commented 2 years ago

This fix is included here: https://pypi.org/project/doorstop/3.0b6/

myrontuttle commented 2 years ago

Awesome. Thank you!