search

doosan-robotics / API-DRFL

BSD 3-Clause "New" or "Revised" License
13 stars 7 forks source link

Compiler warnings #4

Closed kirillmorozov closed 1 year ago

kirillmorozov commented 2 years ago

When compiling code that uses DRFL API with -Wpendantic -Wextra -Wall options I get the following warnings:

In file included from GL010116/include/DRFLEx.h:62:0,
GL010116/include/DRFL.h:295:6: warning: extra ‘;’ [-Wpedantic]
     };
      ^
GL010116/include/DRFLEx.h:479:6: warning: extra ‘;’ [-Wpedantic]
     };
      ^
GL010116/include/DRFLEx.h: In member function ‘bool DRAFramework::CDRFLEx::set_safe_stop_reset_type(SAFE_STOP_RESET_TYPE)’:
GL010116/include/DRFLEx.h:650:154: warning: no return statement in function returning non-void [-Wreturn-type]
         bool set_safe_stop_reset_type(SAFE_STOP_RESET_TYPE eResetType = SAFE_STOP_RESET_TYPE_DEFAULT) { _set_safe_stop_reset_type(_rbtCtrl, eResetType); }

Is this okay? I think that a missing return statement is not good.

doosan-robotics commented 2 years ago

There are some cases where the return value is omitted because it has changed from the existing design. Thanks for your discovery, we will fix it.

doosan-robotics commented 1 year ago

This is a resolved issue.