dootixsa / photoviewer

PhotoViewer table images with fullscreen and sharing capabilities
MIT License
0 stars 3 forks source link

podspec file #1

Open bash88 opened 2 months ago

bash88 commented 2 months ago

Please rename the file to DootixDeveloperPhotoviewer.podspec and update s.name to DootixDeveloperPhotoviewer.

Else 'npx cap sync' fails with the 'No Podspec found' message.

puniker commented 1 month ago

I have solved this using patch-package, although it would be nice if they solved it in the library... I leave here what I had to change with patch-package:

file: @dootix-developer+photoviewer+3.3.0.patch

diff --git a/node_modules/@dootix-developer/photoviewer/CapacitorCommunityPhotoviewer.podspec b/node_modules/@dootix-developer/photoviewer/DootixDeveloperPhotoviewer.podspec
similarity index 93%
rename from node_modules/@dootix-developer/photoviewer/CapacitorCommunityPhotoviewer.podspec
rename to node_modules/@dootix-developer/photoviewer/DootixDeveloperPhotoviewer.podspec
index a5fda8b..8e1544f 100644
--- a/node_modules/@dootix-developer/photoviewer/CapacitorCommunityPhotoviewer.podspec
+++ b/node_modules/@dootix-developer/photoviewer/DootixDeveloperPhotoviewer.podspec
@@ -3,7 +3,7 @@ require 'json'
 package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

 Pod::Spec.new do |s|
-  s.name = 'CapacitorCommunityPhotoviewer'
+  s.name = 'DootixDeveloperPhotoviewer'
   s.version = package['version']
   s.summary = package['description']
   s.license = package['license']

With this adding the patch-package script, it should work "postinstall": "patch-package"

puniker commented 1 month ago

Fixed in this PR: https://github.com/dootixsa/photoviewer/pull/2

sverdlov commented 1 week ago

Original plugin has been updated to Capacitor 6. So, now we don't need this one