search

doowb / sort-object

Sort the keys in an object.
MIT License
37 stars 6 forks source link

Fix for NPM vulnerability report by updating dependencies to latest versions #15

Closed elpete closed 5 years ago

elpete commented 5 years ago

No code or build changes.

elpete commented 5 years ago

I didn't notice this needing to go back to such old versions of Node. Are you still planning on supporting those? If so, I'll just revert the second commit. It was just for consistency, not needed to resolve the vulnerability report.

doowb commented 5 years ago

Hi @elpete, thanks for the PR!

I didn't notice this needing to go back to such old versions of Node. Are you still planning on supporting those? If so, I'll just revert the second commit. It was just for consistency, not needed to resolve the vulnerability report.

Please do revert it (if it still fails on union-value@2.0.1, you might be able to set that to union-value@1.0.1).

After the patch is published, we can do a major release with the updated dependencies and drop the older versions of node.

doowb commented 5 years ago

Closed by #16