search

dopecodez / Wikipedia

Wikipedia for node and the browser
MIT License
82 stars 19 forks source link

Fix requests UTF8 encoding for special characters #12

Closed bumbummen99 closed 3 years ago

bumbummen99 commented 3 years ago

Add workaround to encode URL as UTF-8 fixing URLs that include special characters such as umlauts like ö

Source: https://github.com/node-fetch/node-fetch/issues/245

bumbummen99 commented 3 years ago

Checks fail due to CC_TEST_REPORTER_ID not being available to forks.

dopecodez commented 3 years ago

Ah, thanks for pointing that out @bumbummen99 .

I read through the reasons for this https://github.community/t/make-secrets-available-to-builds-of-forks/16166 and it doesn't look like there's gonna be a solution from github anytime soon. I'll have to make the secret public or do any of the workarounds mentioned in the ticket. I'll also check out how other open source libraries which have moved to github actions are handling the problem.

dopecodez commented 3 years ago

Other than that, the changes look good, I tested out your fork and its working fine. Thanks for the PR, @bumbummen99 🏅

bumbummen99 commented 3 years ago

Other than that, the changes look good, I tested out your fork and its working fine. Thanks for the PR, @bumbummen99

Can we please get a new release tag including the fix? :smiley:

dopecodez commented 3 years ago

Apologies @bumbummen99. I was planning on releasing it later but got caught up with work. The release is published here: https://github.com/dopecodez/Wikipedia/releases/tag/v1.0.5 and should be available in the npm store.