search

dopecodez / Wikipedia

Wikipedia for node and the browser
MIT License
82 stars 19 forks source link

Failing coverage check on forked Pull Requests #18

Closed dopecodez closed 3 years ago

dopecodez commented 3 years ago

As seen on #17 , #12 , #11 and any other forked PRs to master, the coverage check fails.

The check fails due to CC_TEST_REPORTER_ID which is used in uploading test reports to codeclimate not being available to forks. The discussion at https://github.community/t/make-secrets-available-to-builds-of-forks/16166 is inconclusive, meaning we have to find our own solution or remove the check completely.

Possible solutions include:

  1. Find a way to make CC_TEST_REPORTER_ID available to forks following the above link.
  2. Remove the check from PRs. This will involve playing around with the main.yaml github action file to get it just right.
  3. Non Ideal Make CC_TEST_REPORTER_ID public. This is something we really shouldnt do as people using parts of the code might end up using this secret.
friendofdog commented 3 years ago

I'm not so familiar with CI on Github, but if CC_TEST_REPORTER_ID was made available to forks isn't that the same as making it public? For example, I could just do something like echo $CC_TEST_REPORTER_ID and I'd have the key.

dopecodez commented 3 years ago

I just made a commit to master which should solve this case by using if in the .github ci file. We'll need to test if this works on the next fork before closing this.

dopecodez commented 3 years ago

Thanks for the help everyone, it was fixed by having another look at github actions conditionals.