search

dopecodez / Wikipedia

Wikipedia for node and the browser
MIT License
82 stars 19 forks source link

All the titles were encoded using encodeUriComponent #32

Closed harisangarans closed 2 years ago

harisangarans commented 2 years ago

All the titles were encoded using encodeUriComponent

dopecodez commented 2 years ago

Thanks for the PR, @harisangarans .

However, on testing if this works for search queries with special characters like &^%, it just makes the wikipedia api throw a url malformed error, it actuallly handles it better and throws a not found error if we just use urlencode.

Unfortuanely, i am rejecting this because it doesnt serve much of a useful purpose for us.

dopecodez commented 2 years ago

Closing #31