Fix failing tests - Githubissues

dopefishh / pympi

A python module for processing ELAN and Praat annotation files

MIT License

93 stars 39 forks source link

Fix failing tests #33

Open dopefishh opened 3 years ago

dopefishh commented 3 years ago

Some tests are failing:

[x] test_clean_time_slots
[ ] test_extract
[x] test_shift_annotations

dopefishh commented 3 years ago

test_clean_time_slots and test_shift_annotations were introduced by https://github.com/dopefishh/pympi/pull/21 For now I've reverted this and we need to think about how to implement it properly (taking this property into account when shifting etc.).

xrotwang commented 3 years ago

I added pytest.mark.xfail to the failing tests in my latest PR, in order to get the CI action to pass. These might need to be removed again when fixing the tests.

dopefishh commented 3 years ago

The problem is not in test_extract but in remove_annotation

xrotwang commented 3 years ago

Ok, I think we should remove the pytest.mark.xfail in any case. I just slightly abused this mechanism to get passing tests once, to make sure the CI integration works as expected.