search

doprz / dipc

Convert your favorite images and wallpapers with your favorite color palettes/themes
Apache License 2.0
232 stars 7 forks source link

merged LAB conversion and color approximation, removing an allocation. #4

Closed CordlessCoder closed 1 year ago

CordlessCoder commented 1 year ago

I also added a pre-processing step to the palettes being used right before they're converted to LAB: It now runs a deduplication step, which has a large performance improvement whenever multiple styles of the same theme are used at the same time.

CordlessCoder commented 1 year ago

Added the new themes to the CLI help message

CordlessCoder commented 1 year ago

Also fixed the unstable feature. Tested and compiles on Rust 1.69.0 stable

doprz commented 1 year ago

Thank you, I was working on the duplication issue as some themes like edge have a lot of duplicate values. I'm also rewriting some sections of code so I will push shortly which will hopefully not interfere that much with your PR.

Also, I think it might be a good idea to create feature issues so that they're tracked and can be marked into milestones as I'm almost ready to release v1.0.0-rc.

doprz commented 1 year ago

Before merging, please go over your PR as the changes that I made in PR #5 may conflict with yours + I refactored large parts of the code. Thanks.

CordlessCoder commented 1 year ago

I already went over #5 as well as fixing the conflicts. The changes in PR 5 are great

doprz commented 1 year ago

Ok, I will take a second look at your PR before merging. Great job with these improvements.

doprz commented 1 year ago

Approved!

doprz commented 1 year ago

Some small issues referenced in #10 were fixed by #11.