search

dora-metrics / pelorus

Automate the measurement of organizational behavior
https://pelorus.readthedocs.io/
Apache License 2.0
245 stars 83 forks source link

Update OCP check script and upstream support with the prow changes #1084

Closed mpryc closed 1 year ago

mpryc commented 1 year ago

The PROW CI jobs were updated to use only latest OCP release for their runs. The documentation and the check openshift version script needs to be changed as well.

PROW PR: https://github.com/openshift/release/pull/44348

mateusoliveira43 commented 1 year ago

/hold wait the other PR merge

mpryc commented 1 year ago

/unhold

mpryc commented 1 year ago

/retest-required

mpryc commented 1 year ago

Also need to remove old references in README.md and .github/ISSUE_TEMPLATE/bug.yml

I would also add a deprecated warning (just a comment is enough) to Makefile E2E test scenario 2 command https://github.com/dora-metrics/pelorus/blob/master/Makefile#L126

I left the issue list of older OCP releases. It's a bug entry and we don't force user to use X or Y version of OCP + we should allow to log against already existing deployments.

I don't think we should deprecate scenario-2, we just don't run them in the periodics.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/dora-metrics/pelorus/blob/master/OWNERS)~~ [mateusoliveira43] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mateusoliveira43 commented 1 year ago

I think the regex for PROW is working, it did not trigger for your newest commit that does not touch the files delacred in it :smile:

But I think we left this there https://github.com/openshift/release/blob/master/core-services/prow/02_config/dora-metrics/pelorus/_prowconfig.yaml#L19 we should remove it right?

(if you want, you can bypass branch protection and merge this PR)

mpryc commented 1 year ago

I think the regex for PROW is working, it did not trigger for your newest commit that does not touch the files delacred in it 😄

But I think we left this there https://github.com/openshift/release/blob/master/core-services/prow/02_config/dora-metrics/pelorus/_prowconfig.yaml#L19 we should remove it right?

(if you want, you can bypass branch protection and merge this PR)

I think it's because my PR was after the above was merged, so it got old required jobs.

mpryc commented 1 year ago

/retest required

openshift-ci[bot] commented 1 year ago

@mpryc: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

In response to [this](https://github.com/dora-metrics/pelorus/pull/1084#issuecomment-1766174262): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mpryc commented 1 year ago

/test 4.13-e2e-openshift

openshift-ci[bot] commented 1 year ago

@mpryc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.12-e2e-openshift 1c76e0c624af305c6d649a056566afaf387096ee link true /test 4.12-e2e-openshift
ci/prow/4.11-e2e-openshift 1c76e0c624af305c6d649a056566afaf387096ee link true /test 4.11-e2e-openshift
ci/prow/4.10-e2e-openshift 1c76e0c624af305c6d649a056566afaf387096ee link true /test 4.10-e2e-openshift
ci/prow/4.13-e2e-openshift 16cf9fac3f02baed215ae76550e11e4f1431fdb4 link true /test 4.13-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mpryc commented 1 year ago

Merging as it previously passed checks.