search

dora-rs / dora

DORA (Dataflow-Oriented Robotic Architecture) is middleware designed to streamline and simplify the creation of AI-based robotic applications. It offers low latency, composable, and distributed dataflow capabilities. Applications are modeled as directed graphs, also referred to as pipelines.
https://dora-rs.ai
Apache License 2.0
1.5k stars 79 forks source link

Refuse relative path for remote in coordinator #538

Closed XxChang closed 3 months ago

XxChang commented 3 months ago

Only allow absolute path for remote daemon in coordinator,

modified from https://github.com/dora-rs/dora/pull/534

See option 2 in https://github.com/dora-rs/dora/issues/535

XxChang commented 3 months ago

@Gege-Wang please help me check it in remote daemon

Gege-Wang commented 3 months ago

@XxChang Hi, I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

haixuanTao commented 3 months ago

So this work on aws EC2 right?

And now you should be able to spawn multiple-daemon example without using the same folder structure right?

phil-opp commented 3 months ago

I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

Good point!

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

XxChang commented 3 months ago

I think the machine who executes dora start dataflow.yml is the local machine.In this PR, the local machine is same as the coordinator, right?

Good point!

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

Sure, but if we do that. The "coordinator_addr" optional flag in dora start will be no sense

phil-opp commented 3 months ago

@XxChang Could you add an additional check in dora start that the coordinator IP is local too? Then we can be sure that the coordinator and all relevant daemons run on the same machine.

Sure, but if we do that. The "coordinator_addr" optional flag in dora start will be no sense

I meant as a requirement for absolute paths. Relative paths should be only allowed if the CLI, the coordinator, and the daemon(s) are all on the same machine.

So you can still use --coordinator_addr, but not in combination with relative paths.

XxChang commented 3 months ago

Add additional check in dora start. Only allow relative path to be used in the case that dora-cli and dora-coordinator are in the same machine.

Also modify the ci.yml to left enough space for python-dataflow test case.