search

dora-rs / dora

DORA (Dataflow-Oriented Robotic Application) is middleware designed to streamline and simplify the creation of AI-based robotic applications. It offers low latency, composable, and distributed dataflow capabilities. Applications are modeled as directed graphs, also referred to as pipelines.
https://dora-rs.ai
Apache License 2.0
1.35k stars 67 forks source link

Spawn daemon and coordinator in quiet mode on `dora up` #550

Closed phil-opp closed 3 weeks ago

phil-opp commented 3 weeks ago

Avoids clobbering the stdout with daemon and coordinator log messages. The logs are still available as files.

Builds upon #549

haixuanTao commented 3 weeks ago

I find it confusing that there is an argument --quiet for coordinator and daemon which is required but not when using up

phil-opp commented 3 weeks ago

The flag is optional, not required.

For dora up, we immediately return after spawning the commands in the background. The user will likely reuse this terminal to run other commands. Printing to stdout would then insert daemon/coordinator output at random places into the output of the other command. So I think it makes sense to ignore that output instead for dora daemon and dora coordinator.

Instead of passing a --quiet flag, we could also send the stdout to /dev/null when spawning the process.

For the dora daemon and dora coordinator commands, the situation is different. Those commands block the terminal until the daemon or coordinator exits (or you do ctrl+c). So there is nothing else running in parallel in that terminal. Thus, I think it's fine to see warnings and errors printed to the terminal.