search

dorbel-tech / dorbel-app

Main dorbel node.js app
https://app.dorbel.com
0 stars 1 forks source link

Pre-render search pages #1204

Open virtser opened 7 years ago

virtser commented 7 years ago

We need to be able to pre-render for SEO purposes the search page and its variations:

  1. main - https://app.dorbel.com/search
  2. by city - https://app.dorbel.com/search?q=%7B%22city%22%3A1%2C%22neighborhood%22%3A%22*%22%7D
  3. by city and neighbourhood - https://app.dorbel.com/search?q=%7B%22city%22%3A1%2C%22neighborhood%22%3A21%7D
  4. etc...

Why don't we user for this services like https://prerender.io ? There is a ready koa middleware for this as well: https://github.com/RisingStack/koa-prerender

virtser commented 7 years ago

@avnersorek WDYT?

avnersorek commented 7 years ago

We don't need a service for this - we just need to add a serverPreRender method to Filter.jsx with the data fetching

virtser commented 7 years ago

Depends on the effort. I remember it wasn't that easy to accomplish on apartments.

avnersorek commented 7 years ago

Yeah but I think that included setting up the whole SSR infrastructure. It shouldn't be a big effort.

virtser commented 7 years ago

@zivoko I guess we want a pretty urls here like?

https://app.dorbel.com/search/tel-aviv/ https://app.dorbel.com/search/tel-aviv/1

zivoko commented 7 years ago

@virtser pretty url's will be the best. How will the neighborhood look like in the link? https://app.dorbel.com/search/tel-aviv/1 -or- https://app.dorbel.com/search/tel-aviv/old-north

avnersorek commented 7 years ago

What about country ? https://app.dorbel.com/search/il/tel-aviv/old-north

virtser commented 7 years ago

@zivoko lets have neighborhoods as ids or it can be in local names like: https://app.dorbel.com/search/הצפון הישן/תל-אביב/

@avnersorek I think that every country will have its own domain in the future, so it won't be relevant, but we can make it into url just in case.

virtser commented 7 years ago

@zivoko @TalSarigAvraham putting this issue on hold for now until we define it better.