search

dorbel-tech / dorbel-app

Main dorbel node.js app
https://app.dorbel.com
0 stars 1 forks source link

Evaluate upgrade to koa v2 which uses async instead generator functions #1387

Closed virtser closed 7 years ago

virtser commented 7 years ago

https://github.com/koajs/koa

avnersorek commented 7 years ago

please note that Koa requires node v7.6.0 or higher for ES2015 and async function support.

virtser commented 7 years ago

In this case I would go with latest node v8

avnersorek commented 7 years ago

v8 will be the next LTS version, but is only scheduled to start LTS on October. https://github.com/nodejs/LTS

virtser commented 7 years ago

Isn't it a good sign to start using it? :)

virtser commented 7 years ago

In case of node version upgrade, we need to update our alpine-node image as well: https://github.com/dorbel-tech/alpine-node

avnersorek commented 7 years ago

This will consist of - 1/2/3/4. upgrading Koa in each of our services 5 upgrading middleware signatures in dorbel-shared

I will open separate PR's for 1+2+3+4 and a separate issue for 5

avnersorek commented 7 years ago

pending https://github.com/dorbel-tech/dorbel-shared/issues/93