dorbel-tech / dorbel-app

Main dorbel node.js app
https://app.dorbel.com
0 stars 1 forks source link

Allow to connect with Facebook/Linkeding to prefill its urls in tenant profile #1573

Closed virtser closed 6 years ago

virtser commented 6 years ago

Today, when tenant interested in apartment he need to fill his profile including links to Facebook and Linkedin. It is very hard to go any copy & paste those links from social networks. What if we allow them just to do Facebook and Linkedin connect and auto fill the urls for them?

dorbel_-_ _3_ _ _ _and_1__bash
avnersorek commented 6 years ago

Small product/design question - If we load those links automatically (let's say the user has a Facebook login already), it looks like this - image

There is no indication to what this is, the user just sees a textbox filled with some strange letters from the future that only advanced computers can understand ;)

Maybe we should replace it with an indication (that's a valid link or something like that) or at least add a label above the text box ?

virtser commented 6 years ago

I agree.

avnersorek commented 6 years ago

BTW @virtser Do we have a LinkedIn app ? we need to connect that to Auth0 for the LinkedIn part

virtser commented 6 years ago

Yes, it is already connected on auth0 dorbel-dev

On Thu, Sep 14, 2017, 12:18 Avner Sorek notifications@github.com wrote:

BTW @virtser https://github.com/virtser Do we have a LinkedIn app ? we need to connect that to Auth0 for the LinkedIn part

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dorbel-tech/dorbel-app/issues/1573#issuecomment-329424101, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcmblHniaywcjOcFcGlOw4LU-Cn-Xgiks5siO9QgaJpZM4PSuel .

--

David VirtserVP R&D @ dorbel M: +972-544-472-571

Linkedin https://il.linkedin.com/in/virtser | www.dorbel.com

avnersorek commented 6 years ago

@zivoko Please approve this UI - Before connect - image After connect - image

The way it works is -

  1. You click on the button
  2. You get a popup where you need to approve the dorbel app in your FB/LI account
  3. The popup closes and you continue the flow

Also - regarding LinkedIn login - do we want to add it to the default login dialog as an option ?

Thanks

zivoko commented 6 years ago

@avnersorek the UI looks fine, but please limit the width of the buttons to 15px from the text on each side. (currently the buttons look too wide.. )

avnersorek commented 6 years ago

@zivoko Currently there is no such option. The Facebook/LinkedIn connection is per user and can't be cancelled or hidden.

Please define it as different feature if you think it's important.

avnersorek commented 6 years ago

Here it is with smaller buttons. They were wide to be aligned with the text-boxes, this is the whole screen shot : image

virtser commented 6 years ago

Looking good to me.

On Thu, Sep 14, 2017 at 4:54 PM Avner Sorek notifications@github.com wrote:

Here it is with smaller buttons. They were wide to be aligned with the text-boxes, this is the whole screen shot : [image: image] https://user-images.githubusercontent.com/2223502/30433513-4f384cc8-996d-11e7-9c28-2664000ea204.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dorbel-tech/dorbel-app/issues/1573#issuecomment-329489034, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcmbgjT47D_rZQ_ndtGojKfdMq4XDBKks5siS_8gaJpZM4PSuel .

--

David VirtserVP R&D @ dorbel M: +972-544-472-571

Linkedin https://il.linkedin.com/in/virtser | www.dorbel.com