dorbel-tech / dorbel-app

Main dorbel node.js app
https://app.dorbel.com
0 stars 1 forks source link

Shorten sharing links to make it look better #1586

Closed lxngxr closed 6 years ago

lxngxr commented 6 years ago

closes #1555 Implemented on copy link only as agreed. No need for meta tag in listing page server rendered since the crawler will be redirected to the correct url.

codecov[bot] commented 6 years ago

Codecov Report

Merging #1586 into develop will decrease coverage by 0.42%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1586      +/-   ##
===========================================
- Coverage    31.65%   31.23%   -0.43%     
===========================================
  Files          165      167       +2     
  Lines         3718     3768      +50     
  Branches       774      781       +7     
===========================================
  Hits          1177     1177              
- Misses        2506     2556      +50     
  Partials        35       35
Impacted Files Coverage Δ
front-gateway/src/providers/AppProviders.js 0% <ø> (ø) :arrow_up:
...ListingToGroupsModal/ShareListingToGroupsModal.jsx 1.75% <0%> (-0.47%) :arrow_down:
...rc/components/Listing/components/ListingSocial.jsx 2.38% <0%> (-1.07%) :arrow_down:
front-gateway/src/providers/ShortUrlProvider.js 0% <0%> (ø)
front-gateway/src/stores/ShortUrlStore.js 0% <0%> (ø)
front-gateway/src/stores/AppStore.js 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c71116d...c4bb08f. Read the comment docs.