search

dorbel-tech / dorbel-app

Main dorbel node.js app
https://app.dorbel.com
0 stars 1 forks source link

Feature/1590 group share dialog design #1607

Closed amoslande closed 6 years ago

amoslande commented 6 years ago

Closes #1590 WDYT about the React bootstrap modal closeButton param solution I made? Would you rather I override the 3rd party default in our modal wrapper?

codecov[bot] commented 6 years ago

Codecov Report

Merging #1607 into develop will decrease coverage by 1.33%. The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1607      +/-   ##
===========================================
- Coverage    31.62%   30.29%   -1.34%     
===========================================
  Files          166      164       -2     
  Lines         3810     3737      -73     
  Branches       793      793              
===========================================
- Hits          1205     1132      -73     
+ Misses        2569     2503      -66     
- Partials        36      102      +66
Impacted Files Coverage Δ
...mponents/Dashboard/MyProperties/PropertyManage.jsx 54.38% <ø> (-7.02%) :arrow_down:
...ListingToGroupsModal/ShareListingToGroupsModal.jsx 1.58% <ø> (+0.04%) :arrow_up:
...aseStats/SummaryBox/Instances/PropertyValueBox.jsx 3.57% <ø> (ø) :arrow_up:
...ont-gateway/src/components/Dashboard/MyProfile.jsx 0% <ø> (ø) :arrow_up:
...s/Dashboard/MyProperties/ListingStatusSelector.jsx 6.06% <ø> (ø) :arrow_up:
...t-gateway/src/components/LikeButton/LikeButton.jsx 2.32% <ø> (ø) :arrow_up:
.../components/ApartmentForm/UploadApartmentStep2.jsx 0% <ø> (ø) :arrow_up:
...way/src/components/Tenants/TenantRow/TenantRow.jsx 67.44% <ø> (-2.33%) :arrow_down:
...gateway/src/components/DorbelModal/DorbelModal.jsx 7.69% <0%> (ø) :arrow_up:
front-gateway/src/providers/ModalProvider.js 0% <0%> (ø) :arrow_up:
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa45c57...4fdcfad. Read the comment docs.