search

dorbel-tech / dorbel-shared

dorbel shared dependencies used in dorbel-app
0 stars 1 forks source link

Add more unit test for dorbel-shared modules #35

Open virtser opened 7 years ago

virtser commented 7 years ago

Based on code coverage: https://codecov.io/gh/dorbel-tech/dorbel-shared/tree/f8a5882633ed6f50cc4cdd11ebff671653b049f1/src

virtser commented 7 years ago

I think we are not done with testing it just yet...

avnersorek commented 7 years ago

continuing work in https://github.com/dorbel-tech/dorbel-shared/tree/feature/even-more-unit-tests

virtser commented 7 years ago

@avnersorek can you open PR on the work that you did here to submit it?

virtser commented 7 years ago

user/management.js should be tested throughout.

avnersorek commented 7 years ago

doesn't add a lot but let's at least finish that - https://github.com/dorbel-tech/dorbel-shared/pull/82

virtser commented 7 years ago

Missing tests: user/ - https://codecov.io/gh/dorbel-tech/dorbel-shared/tree/master/src/utils/user utils/ - https://codecov.io/gh/dorbel-tech/dorbel-shared/tree/master/src/utils request-logger - https://codecov.io/gh/dorbel-tech/dorbel-shared/src/master/src/koa-middleware/request-logger.js