search

dorbel-tech / dorbel-shared

dorbel shared dependencies used in dorbel-app
0 stars 1 forks source link

domainErrors are not reported to log #75

Closed virtser closed 7 years ago

virtser commented 7 years ago

https://github.com/dorbel-tech/dorbel-shared/blob/master/src/utils/domainErrors.js

avnersorek commented 7 years ago

IMHO The logging should be where the error is caught - error-handler middleware or something like that

virtser commented 7 years ago

Yes, but now in case of city/neighbourhoods mismatch, only user receives this error on client side and we don't know about it. Maybe domainErrors is not the place, but we need to report such cases so we can be aware of them..

avnersorek commented 7 years ago

yep city/neighbourhoods mismatch should not be a regular ValidationError since it's not just bad user input.

On Thu, Apr 27, 2017 at 2:36 PM, David Virtser notifications@github.com wrote:

Yes, but now in case of city/neighbourhoods mismatch, only user receives this error on client side and we don't know about it. Maybe domainErrors is not the place, but we need to report such cases so we can be aware of them..

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dorbel-tech/dorbel-shared/issues/75#issuecomment-297689130, or mute the thread https://github.com/notifications/unsubscribe-auth/ACHtjlJkyHROr-xYZVNfGIBPI2VaqVoUks5r0H2wgaJpZM4NKC1c .