search

dorian3d / DBoW2

Enhanced hierarchical bag-of-word library for C++
Other
851 stars 367 forks source link

Removed dependencies of DLib #18

Closed rmsalinas closed 7 years ago

rmsalinas commented 8 years ago

Hi,

I have worked on a version that removed DLib depencies. In fact there is very little connection with the DLib library and I think it is safe a appropriate to remove it.

rmsalinas commented 8 years ago

Hi, take a look at the new version. I have made many changes so I think it would be interesting to set new name DBoW3.

The main point is that not it can handle any type of opencv descriptor (both binary and non-binary) out of the box, i.e., it is not longer neccesary to reimplement based on the type of descriptor. Also, I have made improvements in the memory management. I let cv::Mat to deal with the issues and I use no pointers any longer.

Because of the new changes, it is not neccesary to use templates for Vocabulary or Database.

It compiles in windows, but I got yet some problems running the demo because it fails (in windows only) when extracting descriptors. But in linux works just fine.

dorian3d commented 8 years ago

Thank you for this addition, making the library more descriptor agnostic is something I like. I prefer to keep the master branch with as little changes as possible, but I think this contribution is valuable and will create a branch for it.

dorian3d commented 7 years ago

This version has been added as a contribution in the contrib/v1.1-free-enhancement-rmsalinas branch.