PATCH.JS - Room Entry Settings in German

[thesosguy]

Hi First off thank you for the work on the Docker Version I just swapped my installation from a standard installation. The process could not have been simpler.

I found that there are 2 German words in the patch.js file Registrierung and Serieneinstellungen line 71 and 72.

Now it is an easy fix from within the container but it just need to be done after each container restart.

Would there be a way to change that or to update the theme to follow the language set in config.inc.php - in my case English

Other then that everything seems to work perfectly.

Thanks

[dorianim]

Hey,

the issue is this: In other views, like edit_area.php, the fieldsets have a title (or legend):

Or in code: https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_area.php#L211

In those cases, the legends are used as the title of the collapsible cards.

In the edit_entry.php view, however, the fieldsets do not have legends. A legend would be needed for the registration: https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_entry.php#L922

and rep_info: https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_entry.php#L1014

fieldsets. Also, these two words would need a translation: https://github.com/meeting-room-booking-system/mrbs-code/blob/main/web/lang/lang.en

So I'd suggest opening an issue or PR in the mrbs-code repo to add those legends and translations there. Otherwise, it will be a pain to maintain in the long run.

[thesosguy]

Makes perfect sense,

Thank you for the quick response! I appreciate the work you have put in!

On Wed, Jan 3, 2024 at 4:20 AM Dorian Zedler @.***> wrote:

Hey,

the issue is this: In other views, like edit_area.php, the fieldsets have a title (or legend ): image.png (view on web) https://github.com/dorianim/modern-mrbs-theme/assets/30153207/6f1172d0-b377-4f6f-a2a6-69aebea12991

Or in code:

https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_area.php#L211

In those cases, the legends are used as the title of the collapsible cards.

In the edit_entry.php view, however, the fieldsets do not have legends. A legend would be needed for the registration:

https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_entry.php#L922

and rep_info:

https://github.com/meeting-room-booking-system/mrbs-code/blob/6351c44f611922a0dd392e7f25feb06ec4756ea4/web/edit_entry.php#L1014

fieldsets. Also, these two words would need a translation:

https://github.com/meeting-room-booking-system/mrbs-code/blob/main/web/lang/lang.en

So I'd suggest opening an issue or PR in the mrbs-code repo https://github.com/meeting-room-booking-system/mrbs-code to add those legends and translations there. Otherwise, it will be a pain to maintain in the long run.

— Reply to this email directly, view it on GitHub https://github.com/dorianim/modern-mrbs-theme/issues/8#issuecomment-1875057760, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXYB6VFO3B5XXCPX5R7MDSLYMUPEPAVCNFSM6AAAAABBKVGEV6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZVGA2TONZWGA . You are receiving this because you authored the thread.Message ID: @.***>