search

dorianj / CoRD

CoRD is a Mac OS X remote desktop client for Microsoft Windows computers using the RDP protocol. It's easy to use, fast, and free for anyone to use or modify.
http://cord.sourceforge.net/
345 stars 135 forks source link

Crashing possibly due to Dec 3 update to Remote Desktop Client v 3.7.1 #55

Closed cyates81 closed 10 years ago

cyates81 commented 10 years ago

Hello,

CoRD started crashing on me today and the only change made from when it was stable is a system update to Remote Desktop Client done on 12/3/2013. It crashes anywhere from 1-10 seconds after connecting.

Process: CoRD [513] Path: /Users/USER/*/CoRD.app/Contents/MacOS/CoRD Identifier: net.sf.cord Version: 0.5.7 (5701) Code Type: X86-64 (Native) Parent Process: launchd [275] Responsible: CoRD [513] User ID: 501

Date/Time: 2013-12-05 09:54:37.987 -0800 OS Version: Mac OS X 10.9 (13A603) Report Version: 11 Anonymous UUID: 532B7D61-68E3-9FE9-B688-1DE4FCC4E7E7

Crashed Thread: 10

Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000001

VM Regions Near 0x1: --> __TEXT 0000000100000000-000000010004a000 [ 296K] r-x/rwx SM=COW /Users/USER/*/CoRD.app/Contents/MacOS/CoRD

Thread 0:: Dispatch queue: com.apple.main-thread 0 libsystem_kernel.dylib 0x00007fff80cb3a1a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff80cb2d18 mach_msg + 64 2 com.apple.CoreFoundation 0x00007fff89bcb315 CFRunLoopServiceMachPort + 181 3 com.apple.CoreFoundation 0x00007fff89bca939 CFRunLoopRun + 1161 4 com.apple.CoreFoundation 0x00007fff89bca275 CFRunLoopRunSpecific + 309 5 com.apple.HIToolbox 0x00007fff841edf0d RunCurrentEventLoopInMode + 226 6 com.apple.HIToolbox 0x00007fff841edcb7 ReceiveNextEventCommon + 479 7 com.apple.HIToolbox 0x00007fff841edabc _BlockUntilNextEventMatchingListInModeWithFilter + 65 8 com.apple.AppKit 0x00007fff8738928e _DPSNextEvent + 1434 9 com.apple.AppKit 0x00007fff873888db -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 10 com.apple.AppKit 0x00007fff8737c9cc -[NSApplication run] + 553 11 com.apple.AppKit 0x00007fff87367803 NSApplicationMain + 940 12 net.sf.cord 0x0000000100001e44 start + 52

Thread 1:: Dispatch queue: com.apple.libdispatch-manager 0 libsystem_kernel.dylib 0x00007fff80cb8662 kevent64 + 10 1 libdispatch.dylib 0x00007fff8854c43d _dispatch_mgr_invoke + 239 2 libdispatch.dylib 0x00007fff8854c152 _dispatch_mgr_thread + 52

Thread 2: 0 libsystem_kernel.dylib 0x00007fff80cb3a1a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff80cb2d18 mach_msg + 64 2 com.apple.CoreFoundation 0x00007fff89bcb315 CFRunLoopServiceMachPort + 181 3 com.apple.CoreFoundation 0x00007fff89bca939 CFRunLoopRun + 1161 4 com.apple.CoreFoundation 0x00007fff89bca275 CFRunLoopRunSpecific + 309 5 com.apple.AppKit 0x00007fff875291ce _NSEventThread + 144 6 libsystem_pthread.dylib 0x00007fff833cd899 _pthread_body + 138 7 libsystem_pthread.dylib 0x00007fff833cd72a _pthread_start + 137 8 libsystem_pthread.dylib 0x00007fff833d1fc9 thread_start + 13

Thread 3:: com.apple.NSURLConnectionLoader 0 libsystem_kernel.dylib 0x00007fff80cb3a1a mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff80cb2d18 mach_msg + 64 2 com.apple.CoreFoundation 0x00007fff89bcb315 CFRunLoopServiceMachPort + 181 3 com.apple.CoreFoundation 0x00007fff89bca939 __CFRunLoopRun + 1161 4 com.apple.CoreFoundation 0x00007fff89bca275 CFRunLoopRunSpecific + 309 5 com.apple.Foundation 0x00007fff8817f907 +[NSURLConnection(Loader) _resourceLoadLoop:] + 348 6 com.apple.Foundation 0x00007fff8817f70b NSThreadmain + 1318 7 libsystem_pthread.dylib 0x00007fff833cd899 _pthread_body + 138 8 libsystem_pthread.dylib 0x00007fff833cd72a _pthread_start + 137 9 libsystem_pthread.dylib 0x00007fff833d1fc9 thread_start + 13

Thread 4:: com.apple.CFSocket.private 0 libsystem_kernel.dylib 0x00007fff80cb79aa select + 10 1 com.apple.CoreFoundation 0x00007fff89c16d43 CFSocketManager + 867 2 libsystem_pthread.dylib 0x00007fff833cd899 _pthread_body + 138 3 libsystem_pthread.dylib 0x00007fff833cd72a _pthread_start + 137 4 libsystem_pthread.dylib 0x00007fff833d1fc9 thread_start + 13

Thread 5: 0 libsystem_kernel.dylib 0x00007fff80cb7e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff833cef08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff833d1fb9 start_wqthread + 13

Thread 6: 0 libsystem_kernel.dylib 0x00007fff80cb7e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff833cef08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff833d1fb9 start_wqthread + 13

Thread 7: 0 libsystem_kernel.dylib 0x00007fff80cb7e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff833cef08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff833d1fb9 start_wqthread + 13

Thread 8: 0 libsystem_kernel.dylib 0x00007fff80cb7e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff833cef08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff833d1fb9 start_wqthread + 13

Thread 9: 0 libsystem_kernel.dylib 0x00007fff80cb7e6a __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff833cef08 _pthread_wqthread + 330 2 libsystem_pthread.dylib 0x00007fff833d1fb9 start_wqthread + 13

Thread 10 Crashed: 0 net.sf.cord 0x000000010003205c ui_draw_text + 1185 1 net.sf.cord 0x000000010001b81d process_orders + 10629 2 net.sf.cord 0x000000010001eb71 rdp5_process + 377 3 net.sf.cord 0x000000010001c7c7 rdp_recv + 103 4 net.sf.cord 0x0000000100026f9e -[CRDSession stream:handleEvent:] + 122 5 com.apple.CoreFoundation 0x00007fff89c19f11 _signalEventSync + 385 6 com.apple.CoreFoundation 0x00007fff89c19d58 _cfstream_solo_signalEventSync + 328 7 com.apple.CoreFoundation 0x00007fff89c19bcf _CFStreamSignalEvent + 623 8 com.apple.CFNetwork 0x00007fff82247f9a CoreReadStreamCFStreamSupport::coreStreamReadEvent(CoreReadStream_, unsigned long) + 102 9 com.apple.CFNetwork 0x00007fff82247f09 CoreReadStreamClient::coreStreamEventsAvailable(unsigned long) + 53 10 com.apple.CFNetwork 0x00007fff8237ba45 CoreStreamBase::callClientNow(CoreStreamClient) + 53 11 com.apple.CFNetwork 0x00007fff82247c29 CoreStreamBase::streamSetEventAndScheduleDelivery(unsigned long, unsigned char) + 183 12 com.apple.CFNetwork 0x00007fff822479b4 SocketStream::dispatchSignalFromSocketCallbackUnlocked(SocketStreamSignalHolder) + 74 13 com.apple.CFNetwork 0x00007fff822470ba SocketStream::socketCallback(_CFSocket, unsigned long, CFData const, void const) + 208 14 com.apple.CFNetwork 0x00007fff82246fba SocketStream::_SocketCallBack_stream(CFSocket_, unsigned long, _CFData const, void const, void) + 64 15 com.apple.CoreFoundation 0x00007fff89c19397 CFSocketPerformV0 + 855 16 com.apple.CoreFoundation 0x00007fff89bd98f1 CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION + 17 17 com.apple.CoreFoundation 0x00007fff89bcb062 CFRunLoopDoSources0 + 242 18 com.apple.CoreFoundation 0x00007fff89bca7ef CFRunLoopRun + 831 19 com.apple.CoreFoundation 0x00007fff89bca275 CFRunLoopRunSpecific + 309 20 com.apple.Foundation 0x00007fff88181a7c -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 253 21 net.sf.cord 0x0000000100027fef -[CRDSession runConnectionRunLoop] + 151 22 net.sf.cord 0x000000010000b37d -[AppController(Private) connectAsync:] + 348 23 com.apple.Foundation 0x00007fff8817f70b NSThread__main + 1318 24 libsystem_pthread.dylib 0x00007fff833cd899 _pthread_body + 138 25 libsystem_pthread.dylib 0x00007fff833cd72a _pthread_start + 137 26 libsystem_pthread.dylib 0x00007fff833d1fc9 thread_start + 13

Thread 10 crashed with X86 Thread State (64-bit): rax: 0x0000000000000000 rbx: 0x0000000109754565 rcx: 0x00000000000001ae rdx: 0x0000000000000000 rdi: 0x0000000109754000 rsi: 0x0000000000000080 rbp: 0x0000000107e9f6d0 rsp: 0x0000000107e9f5e0 r8: 0x402a000000000000 r9: 0xffff9fffffb9743f r10: 0x000000010070b2d0 r11: 0x00007fff713cf138 r12: 0x0000000109754000 r13: 0x0000000000000002 r14: 0x00000000000000ec r15: 0x0000000109836060 rip: 0x000000010003205c rfl: 0x0000000000010206 cr2: 0x0000000000000001

Logical CPU: 0 Error Code: 0x00000004 Trap Number: 14

cyates81 commented 10 years ago

Changing CRDDrawingGlue.m line 899 from

if (entry != NULL)

to

if (entry != NULL && entry->data != NULL)

seems to have fixed the issue for me.

dorianj commented 10 years ago

Thanks for the fix, will be included in next release